User "Hashar" posted a comment on MediaWiki.r92005.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92005#c19505
Commit summary:
Fix r14202 (!!): this validates the protocol against the regex for the second
time (preg_split has already made sure it matches wfUrlProtocols() so no need),
and uses strpos() to validate against a regex (that's just wrong). I'm removing
it not because it's useless but because it breaks for URL protocols that don't
contain a ':' ('//' in my case) for no reason at all. Found out about this when
writing parser tests for it (will commit these in a minute), so yay tests!
Comment:
Wonderful!!! Great to see bugs getting smashed thanks to testing.
As stated on IRC, please make sure there is no regression for bug 5918.
<nowiki>
[ftp://foobar] is autonumbered.
</nowiki>
<nowiki>
ftp://foobar is still a free link.
</nowiki>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
