User "Catrope" posted a comment on MediaWiki.r92005.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92005#c19533
Commit summary:
Fix r14202 (!!): this validates the protocol against the regex for the second
time (preg_split has already made sure it matches wfUrlProtocols() so no need),
and uses strpos() to validate against a regex (that's just wrong). I'm removing
it not because it's useless but because it breaks for URL protocols that don't
contain a ':' ('//' in my case) for no reason at all. Found out about this when
writing parser tests for it (will commit these in a minute), so yay tests!
Comment:
CodeReview mangled your comment, so it's not quite clear what you meant, but
the parser test for bug 5918 still passes. I guess another way of saying it is
that bug 5918 applied to protocol-relative URLs before this change.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
