User "Jeroen De Dauw" posted a comment on MediaWiki.r92382. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92382#c19815 Commit summary:
added special page which will serve as admin interface for campaign config Comment: > don't use $GLOBALS['wgUser'], we use $wgUser everywhere else. Why introduce a global into your whole local scope when only using it once? Acceding it directly via $GLOBALS seems cleaner. > just please add types to your @params consistently. I normally do, unless it's docs copied from somewhere, or code where I don't know what the type is supposed to be. > change 'uploadcampaigns' to use the 'mwe-upwiz-' prefix Done in r92602 :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
