User "NeilK" posted a comment on MediaWiki.r92382. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92382#c19822 Commit summary:
added special page which will serve as admin interface for campaign config Comment: We're doing an exercise in code review today at the WMF, so I happened to have Brion Vibber right next to me... we reviewed it together. We know that your code is right, but it's just a little bit extra mental effort to connect $wgUser and $GLOBALS['wgUser']. Plus, people grep for globals with "$wg" sometimes. I don't quite see your point that $GLOBALS['wgUser'] is much safer. We have a convention and no other variables should be named $wg-anything. As for @param types, I know that some of my code does this inconsistently too, but we're trying to get better. ;) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
