User "Brion VIBBER" posted a comment on MediaWiki.r86622. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86622#c19996 Commit summary:
(bug 22209, bug 22574) Make indent, bullet list and numbered list buttons in the WikiEditor toolbar act on each line individually * Reintroduce support for the splitlines argument in encapsulateSelection(). Was implemented by Adam Miller in r61493 but got lost somehow * Add 'splitlines': true for the bullet list and numbered list buttons. The indent button already had it, so that part of r61493 did survive * Copy options.pre and options.post to local pre and post variables instead of using (and modifying!) them directly all over the place Comment: What's the hurry? Release is weeks or months away in either case, and writing a test will give that release higher confidence. '''If you can't test it, you can't review it.''' Is there something in particilar that makes these tests impossible to write? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
