User "RobLa-WMF" posted a comment on MediaWiki.r86622. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86622#c20010 Commit summary:
(bug 22209, bug 22574) Make indent, bullet list and numbered list buttons in the WikiEditor toolbar act on each line individually * Reintroduce support for the splitlines argument in encapsulateSelection(). Was implemented by Adam Miller in r61493 but got lost somehow * Add 'splitlines': true for the bullet list and numbered list buttons. The indent button already had it, so that part of r61493 did survive * Copy options.pre and options.post to local pre and post variables instead of using (and modifying!) them directly all over the place Comment: The hurry is that we have 673 new and fixme right in the 1.18 branch, and even once we get to zero on that branch, we'll potentially have a large backlog that will have built up since our July 18 branch date. Once we are down to zero and have more frequent releases, then being more stringent about retroactively writing tests will potentially speed us up, since reverting will be easier. If reverting this revision is fairly simple (relative to writing a test), and if you (Brion) prefer to revert than to make this change, I'd be happy with that resolution. If, however, the only reasonable way forward is writing a test, and we take Roan at his word that he's overloaded (which is pretty obvious from observation), then I'd rather let the test slide than heap on more. Re: "release is weeks or months away in either case". That's how it becomes "months". _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
