User "Catrope" changed the status of MediaWiki.r92815. Old Status: new New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r92815. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92815#c20021 Commit summary: Actually alias sessionkey to filekey, fixes bug in r92459 Comment: <pre> + if ( !$params['filekey'] && $params['sessionkey'] ) { </pre> I missed a similar thing in the previous rev, but: you should be checking for <code>!== null</code> instead of casting to boolean. The latter has lots of nasty and usually unintended effects, because things like the empty string or the string <code>'0'</code> can also evaluate to false. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
