User "Raindrift" changed the status of MediaWiki.r92815. Old Status: fixme New Status: new
User "Raindrift" also posted a comment on MediaWiki.r92815. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92815#c20027 Commit summary: Actually alias sessionkey to filekey, fixes bug in r92459 Comment: Totally, but I did that on purpose: in this case, it fails in the correct direction: I intend to disallow 0 (string or number), empty string, and null. None of those are valid session keys, and I can imagine cases where one might be supplied, especially if the caller is written in a weakly typed language. There's a failure much later that rejects keys that don't match a regexp, but passing such cases through seems like a less graceful way to handle it. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
