User "Nikerabbit" posted a comment on MediaWiki.r92922.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92922#c20065
Commit summary:

Finishing banner settings logging. (specifically, changed content flag is now 
accurate, and changed landing pages are also displayed now)

Comment:

I'd use Title::makeTitle(Safe) instead of newFromText. What happened to 
indentation in getIndexField? I'd also use <nowiki><br /></nowiki> if 
outputting it manually.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to