User "Krinkle" posted a comment on MediaWiki.r93515.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93515#c20339
Commit summary:
mediawiki.js request() caching deep level object member access.
- Instead of requesting index 0 of dependancies-argument, and the value of that
of the registry, and the dependancies object in that of which we read the
length property is very deep. Even worse when doing that both in the head and
in the body of a for()-loop.
- Instead caching reference access to dependancies object of the registry item.
- Plus a simple by-value of the length property
Comment:
@Nikerabbit:
Because that would trigger a syntax error as it's one var statement, not two
separate one.
Individual variables are separated by a comma ("<code>var foo, bar;</code> vs.
<code>var foo; var bar;</code>).
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
