User "Dantman" posted a comment on MediaWiki.r93515. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93515#c20340 Commit summary:
mediawiki.js request() caching deep level object member access. - Instead of requesting index 0 of dependancies-argument, and the value of that of the registry, and the dependancies object in that of which we read the length property is very deep. Even worse when doing that both in the head and in the body of a for()-loop. - Instead caching reference access to dependancies object of the registry item. - Plus a simple by-value of the length property Comment: ...that should have been indented. The comment adding an extra line in between the var and the variable doesn't help make it any more understandable. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
