User "Hashar" changed the status of MediaWiki.r89845. Old Status: new New Status: ok
User "Hashar" also posted a comment on MediaWiki.r89845. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89845#c20609 Commit summary: Review of unit test suites * There's more than ok(), equal() and deepEqual(). Using the others as appropriate. ** Considered: strictEqual(a,b) tests the same as ok(a===b). But the latter doesn't include the values in the report when it fails. So strictEqual saves a lot of time in debugging (especially on TestSwarm where the report is all you have, there "not okay" or "Expected { foo: 500 }, Given: ['bar', '250']" is a big saver. * Adding an "expect" to every test. * Applying whitespace conventions and bringing consistency in the use of mw, mediaWiki, $, $j, jQuery. (except in the initial test where the aliases are being checked) * Added cleanup for added CSSStyleSheet * Making IPtest more complete (Based on IPTest.php) Comment: You should probably have broken this commit in smaller ones :-) DeepEquals is great _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
