User "Catrope" changed the status of MediaWiki.r85203. Old Status: new New Status: ok
User "Catrope" also posted a comment on MediaWiki.r85203. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85203#c20610 Commit summary: * Moved all <link> definitions in OutputPage::getHeadLinks() instead of having them in a *lot* of different functions * Also moved there generic <meta> and removed OutputPage::addDefaultMeta() with its $called static local variable which was breaking the output when generating multiple pages on the same request (rebuildFileCache.php, dumpHTML.php) since that function could only be executed completely once for all instances, and not once per instance * Moved default module from OutputPage::output() to its own function and don't call it when executing a body only request, since it's useless in that case * Call Skin::setMembers() from Skin::initPage() instead of Skin::outputPage() Comment: Inspected by me and three other core coders, and has been in trunk for 5 months without breaking anything. Marking OK. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
