User "Krinkle" posted a comment on MediaWiki.r94289.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94289#c20656
Commit summary:
* Added rev_sha1 and ar_sha1 columns to revision/archive tables (useful for bug
25312)
* Created a script to populate these fields (doesn't handle archive rows
without ar_rev_id set though)
Comment:
Brakes the unit tests for upgrades under SQLite:
<pre>
DatabaseSqliteTest::testUpgrades
Mismatching columns for table "archive" upgrading from 1.15 to 1.19alpha
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
[8] => ar_rev_id
- [9] => ar_sha1
- [10] => ar_text
- [11] => ar_text_id
- [12] => ar_timestamp
- [13] => ar_title
- [14] => ar_user
- [15] => ar_user_text
+ [9] => ar_text
+ [10] => ar_text_id
+ [11] => ar_timestamp
+ [12] => ar_title
+ [13] => ar_user
+ [14] => ar_user_text
)
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/includes/db/DatabaseSqliteTest.php:218
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/MediaWikiTestCase.php:64
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/MediaWikiPHPUnitCommand.php:20
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/phpunit.php:60
</pre>
>From your previous I comment I get that they're not added yet so this may be
>because of that, reporting here just in case.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
