User "Catrope" posted a comment on MediaWiki.r94289.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94289#c20667
Commit summary:
* Added rev_sha1 and ar_sha1 columns to revision/archive tables (useful for bug
25312)
* Created a script to populate these fields (doesn't handle archive rows
without ar_rev_id set though)
Comment:
<pre>
+ AND $idCol IS NOT NULL AND {$prefix}_sha1 IS
NOT NULL";
</pre>
Since rev_sha1 and ar_sha1 are declared as NOT NULL, an IS NOT NULL condition
on them is pointless.
Looks good to me otherwise, but I want Chad to look at how the updater calls
the population script.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
