User "Dantman" changed the status of MediaWiki.r94375. Old Status: fixme New Status: new
User "Dantman" also posted a comment on MediaWiki.r94375. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94375#c20741 Commit summary: Touch up Title::get[Full|Local]URL. This concept of "if not an existing interwiki getFullURL calls getLocalURL" and "if external (interwiki) getLocalURL calls getFullURL" is ridiculous. In fact if mInterwiki just happens to not be '' and not exist, you create infinite recursion and php dies. Instead of having getFullURL and getLocalURL call each other, move the interwiki workload into getLocalURL, and make getFullURL simply call getLocalURL then expand it (use the wf method in case it's already a full url) and append the fragment to it. Comment: Fixed in r94458; Since we determined there are problems with both PROTO_RELATIVE and PROTO_CURRENT as a default for wfExpandUrl in various places and that it would be best if the PROTO arg was required I applied PROTO_RELATIVE to the call. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
