User "Krinkle" posted a comment on MediaWiki.r94433.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94433#c20759
Commit summary:

(bug 26486) ResourceLoader modules with paths to nonexistent files cause PHP 
warnings/notices to be thrown. Worked around all of them using file_exists() 
checks, and introduced a safe wrapper around filemtime() that checks for 
file_exists(). The only warning I couldn't squash is "Warning: array_map(): An 
error occurred while invoking the map callback" but that's due to a bug in PHP, 
which I've reported at https://bugs.php.net/bug.php?id=55416

Comment:

Wouldn't this make debugging harder if a script isn't loaded ? Is there some 
indication somewhere if there's a ResourceLoaderFileModule with an inexistent 
file path as a script ?

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to