User "Catrope" posted a comment on MediaWiki.r94433. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94433#c20771 Commit summary:
(bug 26486) ResourceLoader modules with paths to nonexistent files cause PHP warnings/notices to be thrown. Worked around all of them using file_exists() checks, and introduced a safe wrapper around filemtime() that checks for file_exists(). The only warning I couldn't squash is "Warning: array_map(): An error occurred while invoking the map callback" but that's due to a bug in PHP, which I've reported at https://bugs.php.net/bug.php?id=55416 Comment: Yes, we already throw exceptions if a file doesn't exist when we try to load it, but not when we check its timestamp. That seems reasonable to me. Actually, the remaining warning is thrown precisely because we map <code>readScriptFile()</code> on an array of script files and then throw an exception from inside that function. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
