User "NeilK" posted a comment on MediaWiki.r92009. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92009#c20816 Commit summary:
Refactored UploadStash and related classes to use the database for file metadata storage instead of the session, see bug 26179 Tweaked the UploadWizard to work properly with the new backend code, updated tests Comment: In UploadStash.php line 50, the function is returning a boolean value. So that's correct to use ||. The other cases (line 77,81) I agree. That is perplexing. Not sure why this even works now. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
