User "NeilK" posted a comment on MediaWiki.r92009.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92009#c20821
Commit summary:

Refactored UploadStash and related classes to use the database for file 
metadata storage instead of the session, see bug 26179

Tweaked the UploadWizard to work properly with the new backend code, updated 
tests

Comment:

Ian - you can check if the listFiles() function is broken by uploading a couple 
of files, and then not proceeding to describe them. In another tab open: 
http://yoursite/wiki/Special:UploadStash

I think I understand the problem with initializeFromRequest. That code path 
isn't even touched by UploadWizard, since it uses the API. Only Special:Upload 
uses it. To trigger it, you have to craft a problem with the file that won't be 
caught by Special:Upload, which will cause it to be stashed. An example might 
be to try a file like SANY_12345.JPG, because (if you copied the Commons 
config) that's a Blacklisted title but isn't caught by any hardcoded checks. 
Then, even if you fix the stash, nothing seems to happen; you get sent back to 
an "empty" upload form.



_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to