User "NeilK" posted a comment on MediaWiki.r94966. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94966#c21292 Commit summary:
Two bugs: 1. When the user isn't passed to UploadFromStash::__construct(), it would break when it shouldn't. 2. When stashing files, sometimes an instance of UnregisteredLocalFile would be returned instead of UploadStashFile Comment: Why shouldn't it break if there's no user? Not that we should call a method on a nonexistent object but shouldn't we give up in some other graceful way? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
