User "^demon" posted a comment on MediaWiki.r94966. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94966#c21330 Commit summary:
Two bugs: 1. When the user isn't passed to UploadFromStash::__construct(), it would break when it shouldn't. 2. When stashing files, sometimes an instance of UnregisteredLocalFile would be returned instead of UploadStashFile Comment: Callers should be required to pass a user (or a dummy user) to the UploadStash constructor. Force the caller to be evil and use $wgUser, rather than pushing that logic to an otherwise clean implementation. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
