User "Catrope" changed the status of MediaWiki.r92155. Old Status: fixme New Status: resolved
User "Catrope" also posted a comment on MediaWiki.r92155. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92155#c21446 Commit summary: Restructure tab code of mediawiki.special.preferences.js . * 10 levels of indent, really? * Follow up r91869: Instead of setting the title, and later parsing it out and setting id from it, just set the id directly. * Hashes are now in the form #prefsection-personal. This means that they now work in browser with deactivated JS as well. Comment: Done in r95467 by making the HTMLForm bit (which was originally added specifically to support the preferences form anyway) a bit more generic and moving the preferences-specific ID prefix to Preferences.php. Marking this one as resolved; if there's something wrong with the way I fixed it, comment on r95467. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
