User "Catrope" changed the status of MediaWiki.r92155. Old Status: new New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r92155. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92155#c20761 Commit summary: Restructure tab code of mediawiki.special.preferences.js . * 10 levels of indent, really? * Follow up r91869: Instead of setting the title, and later parsing it out and setting id from it, just set the id directly. * Hashes are now in the form #prefsection-personal. This means that they now work in browser with deactivated JS as well. Comment: <pre> + $attributes["id"] = 'prefsection-' . Sanitizer::escapeId( $key, 'noninitial' ); </pre> I'm pretty sure that an identifier as specific as <code>prefsection-</code> does not belong in a generic class like <code>HTMLForm</code>. OK otherwise. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
