User "Happy-melon" changed the status of MediaWiki.r85392. Old Status: fixme New Status: reverted
User "Happy-melon" also posted a comment on MediaWiki.r85392. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85392#c21481 Commit summary: Fix for catchable fatals thrown on invalid titles, follow-up to miscellaneous Context commit pulled out of a hat (let's go for r85252). We must always have a Title object, even on invalid titles, for the purposes of not melting the Skin. The previous method was to make that a barely-existent half-title from SpecialPage::getTitleFor( 'Badtitle' ), where that is a special page which is not actually defined, but exists in the localisation alias lists. Instead, subclass Title as an explicit BadTitle which we can test for. The badtitle error page, which has empty string for its name in all forms, would probably be quite a good test of our JavaScript error checking. Comment: Reverted in r95521. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
