User "Dantman" changed the status of MediaWiki.r93417. Old Status: new New Status: fixme
User "Dantman" also posted a comment on MediaWiki.r93417. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93417#c21482 Commit summary: follow up r93397 — missed msgid Comment: Message-IDs like "<UserMailer4e56b856ae9867.11102601@http://yourwiki.com>" are not valid, the @ portion is supposed to be in a domain format, not a full url. I think we should probably introduce a new config, something like $wgEnotifMessageIDDomain, and handle decision on what domain to use with something like: <source lang=php> if ( $wgEnotifMessageIDDomain ) { $domain = $wgEnotifMessageIDDomain; } elseif ( isset($wgSMTP['IDHost']) && $wgSMTP['IDHost'] ) { $domain = $wgSMTP['IDHost']; } else { $url = wfParseUrl($wgServer); $domain = $url['host']; } // [...] return "<$msgid@$domain>"; </source> Also, I don't really know about the 'UserMailer' prepend. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
