User "Catrope" changed the status of MediaWiki.r95631. Old Status: new New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r95631. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95631#c21675 Commit summary: Follow up to r79941 To me it doesn't seem like there is a reason that the modules should be publicized in the api. The modules need to be loaded locally, so the dependancy is already on local loading. Adding a new ext.liquidThreads.edit module to do the loading of the edit mode of lqt as well as dependancy loading. Comment: <pre> + 'dependancies' => array( 'ext.liquidThreads', 'ext.wikiEditor', 'ext.wikiEditor.toolbar.i18n', </pre> How did this rev even work for you locally if you misspelled <code>'dependencies'</code>? Looks fine otherwise. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
