User "Catrope" changed the status of MediaWiki.r95260. Old Status: new New Status: ok
User "Catrope" also posted a comment on MediaWiki.r95260. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95260#c21927 Commit summary: add functions that support close and rename of output files as they are being written, used to write out checkpoint files at regular intervals during XML dump production Comment: Fixed some things that irked me in r96275. <pre> + function closeRenameAndReopen( $newname ) { + function rename( $newname ) { + function getFilename() { </pre> These functions are undocumented. closeRenameAndReopen() was documented in a subclass, so I moved that doc comment up to the parent class, but the other two aren't documented anywhere. <pre> + $command = "7za a -bd -si " . wfEscapeShellArg( $file ); + $command .= ' >' . wfGetNull() . ' 2>&1'; </pre> The command building, both here and in DumpPipeOutput, is duplicated and should be factored out. Good enough for deployment, so marking OK, but please do document the new code and fix the code duplication you introduced. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
