User "Reedy" changed the status of MediaWiki.r95260. Old Status: fixme New Status: ok
User "Reedy" also posted a comment on MediaWiki.r95260. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95260#c22957 Commit summary: add functions that support close and rename of output files as they are being written, used to write out checkpoint files at regular intervals during XML dump production Comment: Per the fixme on r97744 <pre> function closePage() { return " </page>\n"; + if (! $this->firstPageWritten) { + $this->firstPageWritten = $this->pageInProgress; + } + $this->lastPageWritten = $this->pageInProgress; } </pre> Did you mean to add the code AFTER the return, so hence, it will never be reached? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
