User "Krinkle" posted a comment on MediaWiki.r95396.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21952
Commit summary:

Merge the iwtransclusion branch back into trunk

Hexmode fixed broken unit tests in revisions after last time

Comment:

I agree, this seems like a perfect thing to go into an extension.

A few side notes:
* It uses global $wgUser->getSkin();
** No need for globals here. OutputPage extends ContextSource which means it 
has both getUser and getSkin on itself.
* CSS classnames used like <code>distantTemplatesUsed</code> and 
<code>mw-templatesUsedExplanation</code> should user lowercase and separation 
by dash, and where needed prefixed with atleast <code>mw-</code>.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to