User "Hashar" posted a comment on MediaWiki.r94951.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94951#c22084
Commit summary:

new method to parse chunk delimiters

Their format is a one liner:
@@ -l,s +l,s @@

See http://en.wikipedia.org/wiki/Diff#Unified_format

Comment:

I can not reproduce the issue using the same parameter you had: '@@ -1,63 +0,0 
@@'. The exception is thrown because the delimiter was not recognized by the 
following regex:

 $n = "(\d+)"
 "/^@@ -$n,$n \+$n,$n @@$/"

There is most probably a funny character sneaking around. Maybe the end of line 
under windows? :-(  Anyway, I will need a test to reproduce the issue, such a 
test was added with follow up r96484

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to