User "Hashar" posted a comment on MediaWiki.r94951.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94951#c23046
Commit summary:

new method to parse chunk delimiters

Their format is a one liner:
@@ -l,s +l,s @@

See http://en.wikipedia.org/wiki/Diff#Unified_format

Comment:

I do not have a Windows install to reproduce the issue. Looks like the issue is 
caused by \n vs \r\n under Windows:

 explode( "\n", $text )

which eans each line will probably still have a \r at the end.  We need a 
wfIsWindows() call to handle the issue or we can call rtrim() on each line to 
sanitize it.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to