User "Krinkle" posted a comment on MediaWiki.r96863. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96863#c22383 Commit summary:
RL2: Move category title message logic to GadgetRepo::getCategoryTitle(). This BREAKS using wikitext in category titles (->plain() is used throughout), which was already broken in some places, wasn't documented that I know of. Besides, enwiki didn't even use it :) Comment: Since ForeignGadgetRepos extends GadgetRepo, perhaps document that <code>getCategoryTitle</code> must only be used for local gadgets ? Or perhaps abstract it and implement in LocalGadgetRepo and return null/false in ForeignGadgetRepos. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
