User "Catrope" posted a comment on MediaWiki.r96863. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96863#c22519 Commit summary:
RL2: Move category title message logic to GadgetRepo::getCategoryTitle(). This BREAKS using wikitext in category titles (->plain() is used throughout), which was already broken in some places, wasn't documented that I know of. Besides, enwiki didn't even use it :) Comment: It is local-only that's true. Re-implementing static functions in child classes only works 'properly' in PHP 5.3, using late static bindings. Also, given that the callers use the class name explicitly when calling the function (<code>GadgetRepo::foo()</code>), it's not a big deal. But yeah it probably makes more sense to put it in LocalGadgetRepo, especially since that's a singleton now. I'll move it. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
