User "Krinkle" posted a comment on MediaWiki.r96999. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96999#c22479 Commit summary:
Followup r96978, clean up code duplication by factoring out the code building load.php requests into ResourceLoader::makeLoaderURL() and makeLoaderQuery() Comment: Looks pretty good. One thing though. Do we really want to introduce two new methods with a list of 10 arguments ? Perhaps change it to have fewer arguments. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
