User "Trevor Parscal" posted a comment on MediaWiki.r96999. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96999#c22492 Commit summary:
Followup r96978, clean up code duplication by factoring out the code building load.php requests into ResourceLoader::makeLoaderURL() and makeLoaderQuery() Comment: You should just pass the context in for most of these, because it's primarily just extracting data out of the context - the method may change, need more data, not need other things, etc. If you passed the context in first, you could get it down to 3 or so arguments, which is more manageable. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
