User "Brion VIBBER" posted a comment on MediaWiki.r85957. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85957#c22560 Commit summary:
Look mum, no globals! Implement a RequestContext for HTMLForm, passed in the constructor. Currently this is optional with B/C; at a later date it should be made compulsory. Doing this removes the need to call $form->setTitle() on every single use; only when you want to set the title to something other than the page context title. Implemented the new syntax in a sample of forms. Also fix a few minor errors in HTMLForm.php that my IDE complained about. Comment: I really don't like this optional parameter in the middle of an argument list; changing order of parameters is dangerous, confusing, and tends to lead to breakage. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
