User "Happy-melon" posted a comment on MediaWiki.r85957.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85957#c22564
Commit summary:
Look mum, no globals! Implement a RequestContext for HTMLForm, passed in the
constructor. Currently this is optional with B/C; at a later date it should be
made compulsory. Doing this removes the need to call $form->setTitle() on
every single use; only when you want to set the title to something other than
the page context title. Implemented the new syntax in a sample of forms. Also
fix a few minor errors in HTMLForm.php that my IDE complained about.
Comment:
Well eventually it should be made ''not'' optional, and for that to happen it
''can't'' go on the end.
/me wants C#-style property setters in constructors <code>new HTMLForm( $fields
,$context ){ $prefix = $myPrefix }</code> ...
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
