User "Mark Bergsma" posted a comment on MediaWiki.r98380. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98380#c23435 Commit summary:
added some error handling around empty or malformed strings, allowed whitespace in the input variables. follow up to revision r98364 Comment: Good changes for robustness, but I don't get domainlist[var.split()] = value.split(). I don't think those variables need to be split still, and in any case, split() returns a list, which can't be used a key for a dict. Do you mean strip() perhaps? We should definitely test this code before we push DNS changes with it _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
