User "Mark Bergsma" posted a comment on MediaWiki.r98380.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98380#c23437
Commit summary:

added some error handling around empty or malformed strings, allowed whitespace 
in the input variables.  follow up to revision r98364

Comment:

exit(1) should probably be sys.exit(1), I don't believe exit() is a global 
built-in function.

We should also check how the calling script(s) react to that - they should 
under no condition push out a partially written out zone file.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to