User "Brion VIBBER" posted a comment on MediaWiki.r98598. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98598#c23579 Commit summary:
* (bug 31289) Fix fatal error on special pages using $this->msg() on PHP 5.2 According to online PHP docs, func_get_args() doesn't work in function parameter lists until PHP 5.3.0. It does, however, work as the *first* parameter, which happens here and there in older code (eg array_slice(func_get_args(),1)). Assigning to a variable and passing through works fine for this case on PHP 5.2.17. Comment: Looks like there's still PHP 5.2 machines in production (which there really should not be ;) -- needs a 1.18wmf1 merge. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
