User "Aaron Schulz" posted a comment on MediaWiki.r98927. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98927#c23764 Commit summary:
(bug 31179) Fixed problems with undeletion making bad page rows: * Moved up isCountable() call, since insertOn() sets the page ID, it safer to do this call first. It now uses master DB data, as it should for reads to write data. Furthermore, calling it after insertOn() was triggered loadPageData() on a slave, breaking the page ID cache just set in insertOn(). * Preemptively call loadPageData( 'fromdbmaster' ) as Article::doEdit() does (r98880) to avoid any lazy loading from the slave which can corrupt the page ID cache. Comment: Gah, I meant "there *was* an off chance". I was referring to the call being *after* the new loadFromDB() call to avoid slave lag. The isCountable() position shouldn't make a difference given the new loadFromDB() call, since no load will be trigger. I just thought it was clearer, as you said. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
