User "Brion VIBBER" posted a comment on MediaWiki.r98927. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98927#c23762 Commit summary:
(bug 31179) Fixed problems with undeletion making bad page rows: * Moved up isCountable() call, since insertOn() sets the page ID, it safer to do this call first. It now uses master DB data, as it should for reads to write data. Furthermore, calling it after insertOn() was triggered loadPageData() on a slave, breaking the page ID cache just set in insertOn(). * Preemptively call loadPageData( 'fromdbmaster' ) as Article::doEdit() does (r98880) to avoid any lazy loading from the slave which can corrupt the page ID cache. Comment: Well now that the loadPageData is forced to master, the only thing that isCountable would get from a slave is the count of pagelinks entries (which is explicitly pulled from DB_SLAVE) and I'm not sure it matters whether you ask up front or down low... _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
