User "Awjrichards" posted a comment on MediaWiki.r98479.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98479#c23959
Commit summary:
Added helper execute methods to process different transaction types. The new
type added was BANK_TRANSFER.
Comment:
<pre>
public function executeBankTransfer( &$wgOut ) {
</pre>
Why are you passing $wgOut by reference here? It doesn't appear to be used in
this function.
<pre>
+ public function executeInsertOrderWithPayment( &$wgOut ) {
</pre>
Similar question. The typical convention would be to do:
<pre>
public function executeInsertOrderWithPayment() {
global $wgOut;
....
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
