User "Reedy" changed the status of MediaWiki.r99863. Old Status: new New Status: fixme
User "Reedy" also posted a comment on MediaWiki.r99863. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99863#c24309 Commit summary: * Added Language::userDate(), Language::userTime() and Language::userTimeAndDate() as new versions of respectively Language::date(), Language::time() and Language::timeanddate(), which take a User object in the second parameter to get time correction and format instead of having to do this when calling the methods and not wanting to user $wgUser's parameters. * Moved Language::userAdjust() near other related function * Updated ENotif stuff to use that functions so that the date format is not taken from the sending user but the receiver * Removed $PAGEEDITDATEANDTIME parameter, unsed and not present in impersonal notification * Also fixed the debug line in UserMailer::send() Comment: <pre> - wfDebug( __METHOD__ . ': sending mail to ' . implode( ',', array( $to->toString() ) ) . "\n" ); + wfDebug( __METHOD__ . ': sending mail to ' . is_array( $to ) ? implode( ', ', $to ) : $to . "\n" ); </pre> <pre> Warning: implode(): Invalid arguments passed in /home/reedy/mediawiki/trunk/phase3/includes/UserMailer.php on line 161 Call Stack: 0.0012 712536 1. {main}() /home/reedy/mediawiki/trunk/extensions/CodeReview/svnImport.php:0 0.0302 1324040 2. require_once('/home/reedy/mediawiki/trunk/phase3/maintenance/doMaintenance.php') /home/reedy/mediawiki/trunk/extensions/CodeReview/svnImport.php:183 0.3533 16843688 3. SvnImport->execute() /home/reedy/mediawiki/trunk/phase3/maintenance/doMaintenance.php:105 91.9781 17274192 4. SvnImport->importRepo() /home/reedy/mediawiki/trunk/extensions/CodeReview/svnImport.php:41 233.4468 26561288 5. CodeRevision->save() /home/reedy/mediawiki/trunk/extensions/CodeReview/svnImport.php:125 233.4731 26571992 6. User->sendMail() /home/reedy/mediawiki/trunk/extensions/CodeReview/backend/CodeRevision.php:514 233.4732 26574120 7. UserMailer::send() /home/reedy/mediawiki/trunk/phase3/includes/User.php:3281 233.4732 26574632 8. implode() /home/reedy/mediawiki/trunk/phase3/includes/UserMailer.php:161 </pre> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
