User "Nikerabbit" changed the status of MediaWiki.r99863. Old Status: new New Status: fixme
User "Nikerabbit" also posted a comment on MediaWiki.r99863. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99863#c24354 Commit summary: * Added Language::userDate(), Language::userTime() and Language::userTimeAndDate() as new versions of respectively Language::date(), Language::time() and Language::timeanddate(), which take a User object in the second parameter to get time correction and format instead of having to do this when calling the methods and not wanting to user $wgUser's parameters. * Moved Language::userAdjust() near other related function * Updated ENotif stuff to use that functions so that the date format is not taken from the sending user but the receiver * Removed $PAGEEDITDATEANDTIME parameter, unsed and not present in impersonal notification * Also fixed the debug line in UserMailer::send() Comment: Why private? Looks like the docs for new methods are copy-pasted unchanged from the internal method, and refer to $type that doesn't exist. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
