User "Brion VIBBER" posted a comment on MediaWiki.r99840. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99840#c24327 Commit summary:
Followup to r99653 (bug 31643) -- reenable client-side thumbnailing of SVGs on Special:Upload, with workaround for Firefox 7 regression. Upstream firefox bug for hang loading some SVGs via data URI: https://bugzilla.mozilla.org/show_bug.cgi?id=694165 A fix may land as soon as Firefox 8. This rev works around the bug by using window.URL.createObjectURL() instead of loading a data URI via FileReader; the object URL loads more cleanly and doesn't have the same hanging bug. Needs to be replicated to UploadWizard (or moved to a shared lib!), some other fixes coming so no rush. Comment: Should merge to 1.18 (release issue -- can cause hangs on Firefox 7) and 1.18wmf1. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
