User "Hashar" posted a comment on MediaWiki.r93702. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93702#c24414 Commit summary:
mediawiki.Title: Removing public setter functions. Title object should be immutable. - To avoid repetition, instead of substituting, changed them to private helper functions - Updated test suite to create new objects for different titles, rather than modifying the existing one. - Adding missing unit tests, now 100% complete according to QUnit CompletnessTest + Test for Title.prototype.getNamespaceId + Test forTitle.prototype.getPrefixedText + Test forTitle.prototype.getExtension Follows-up r90331 CR Comment: Looks like you removed test that create a title given a "name" and a namespace "string": - title = new mw.Title( 'NeilK' ); - title.setNamespace( 'user_talk' ); + title = new mw.Title( 'NeilK', 3 ); The test suite does not seem to test the following code: title = new mw.Title( 'NeilK', 'user_talk' ); _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
