User "Krinkle" posted a comment on MediaWiki.r93702.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93702#c24437
Commit summary:

mediawiki.Title: Removing public setter functions. Title object should be 
immutable.
- To avoid repetition, instead of substituting, changed them to private helper 
functions
- Updated test suite to create new objects for different titles, rather than 
modifying the existing one.
- Adding missing unit tests, now 100% complete according to QUnit 
CompletnessTest
  + Test for Title.prototype.getNamespaceId
  + Test forTitle.prototype.getPrefixedText
  + Test forTitle.prototype.getExtension

Follows-up r90331 CR

Comment:

No, there are no global constants. We do have <code>wgNamespaceIds</code> 
though.


<pre>
> wgNamespaceIds.user_talk
3

> wgNamespaceIds.image
6

> wgNamespaceIds.file
6
</pre>

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to