User "NeilK" posted a comment on MediaWiki.r99941.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99941#c24521
Commit summary:
Applied modified patch by Ben Hartshorne <bhartshorne at wikimedia dot org>:
Leverage MW 1.18's improved image metadata extraction to automatically
extract GPS coordinates, add them to the review workflow, and add a
{{Location dec}} template to the file description page if they have been
provided. This also adds a latitude/longitude fields that the user can
manually fill in, which ultimately should be replacd with a location
picker widget.
Tested in IE7, IE8, Chrome 13, Opera 10, FF7, with single and multiple
files, with and without coordinates.
Comment:
Great work -- marking okay
However, it's not quite ready for production yet. A few notes for followups
from UW devs or Ben...
- Why not record altitude? It's returned by the API
- _this = this -- you probably want var _this = this. JS is not cautiously
scoped, you have to say var before everything.
- It should try to check lat & long for insane or non-numeric values (there's a
validation library that could help)
- If latitude is there, longitude may not be there, despite the assumption
(thanks for documenting that assumption though)
- if ( lat ) is not a strict enough check -- lat can be 0 at the equator. Look
for lat === undefined or something
- locationDiv should have a margin at the bottom, it's a bit visually crowded
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
